linux-kernel - Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1414009627.17121.15.camel@x220>
Date:	Wed, 22 Oct 2014 22:27:07 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Dinh Nguyen <dinguyen@...nsource.altera.com>
Cc:	paulz@...opsys.com, balbi@...com, dinh.linux@...il.com,
	linux-kernel@...r.kernel.org, swarren@...dotorg.org,
	b.zolnierkie@...sung.com, matthijs@...in.nl, r.baldyga@...sung.com,
	jg1.han@...sung.com, sachin.kamat@...aro.org, ben-linux@...ff.org,
	dianders@...omium.org, kever.yang@...k-chips.com,
	linux-usb@...r.kernel.org
Subject: Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote:
> On 10/20/2014 02:42 PM, Paul Bolle wrote:
> > (Side note: drivers/usb/dwc2/Kconfig is sourced (in drivers/usb/Kconfig)
> > even if USB is _not_ set. But USB_DCW2 still depends on USB. Why is
> > that?)
> 
> Because USB is for Host-Side support. DWC2 driver should only get built
> for when USB is enabled. I think you're getting USB and USB_SUPPORT
> mixed up.

No, I don't think I did. Because in drivers/usb/Kconfig we see  
    if USB

    [...]

    endif

    [...]

    source "drivers/usb/dwc2/Kconfig"

    [...]

> In addition, thanks to your comment, I realized that DWC2 should also be
> available to build when USB_GADGET is enabled. A patch has been sent:
> 
> http://marc.info/?l=linux-usb&m=141392377124818&w=2

I haven't checked, but doesn't this mean USB_DWC2 could just depend on
USB_SUPPORT?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/