linux-kernel - Re: [PATCH v3 09/59] dmaengine: Remove the need to declare device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1564848.hByj3lEMqB@avalon>
Date:	Thu, 23 Oct 2014 00:06:13 +0300
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	dmaengine@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Antoine Ténart <antoine@...e-electrons.com>,
	lars@...afoo.de, Russell King <linux@....linux.org.uk>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH v3 09/59] dmaengine: Remove the need to declare device_control

Hi Maxime,

Thank you for the patch.

On Wednesday 22 October 2014 17:43:23 Maxime Ripard wrote:
> In order to migrate the drivers without triggering a BUG_ON for the
> converted drivers, which would cause bisectability issues, we need to
> remove that check before removing the device_control function entirely.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/dma/dmaengine.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index 9b2cd74b8f2e..98e9431f85ec 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -820,8 +820,6 @@ int dma_async_device_register(struct dma_device *device)
> !device->device_prep_dma_sg);
>  	BUG_ON(dma_has_cap(DMA_CYCLIC, device->cap_mask) &&
>  		!device->device_prep_dma_cyclic);
> -	BUG_ON(dma_has_cap(DMA_SLAVE, device->cap_mask) &&
> -		!device->device_control);
>  	BUG_ON(dma_has_cap(DMA_INTERLEAVE, device->cap_mask) &&
>  		!device->device_prep_interleaved_dma);

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/