lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Oct 2014 05:40:26 +0800 From: Greg KH <gregkh@...uxfoundation.org> To: Paul Zimmerman <Paul.Zimmerman@...opsys.com> Cc: Johan Hovold <johan@...nel.org>, Philip Munksgaard <pmunksgaard@...il.com>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] usb: serial: Fix indentation style issue On Wed, Oct 22, 2014 at 09:14:14PM +0000, Paul Zimmerman wrote: > > From: linux-usb-owner@...r.kernel.org [mailto:linux-usb-owner@...r.kernel.org] On Behalf Of Greg KH > > Sent: Wednesday, October 22, 2014 7:19 AM > > > > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote: > > > On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote: > > > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > > > > Fix a style issue > > > > > > > > > > Signed-off-by: Philip Munksgaard <pmunksgaard@...il.com> > > > > > --- > > > > > drivers/usb/serial/option.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > > > > > index d1a3f60..d88998d 100644 > > > > > --- a/drivers/usb/serial/option.c > > > > > +++ b/drivers/usb/serial/option.c > > > > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = { > > > > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) }, > > > > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14), > > > > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist > > > > > - }, > > > > > + }, > > > > > > > > Why not fix the same 'space' issue on the line before this at the same > > > > time? > > > > > > And what about the remaining white-space issues in this file? Do we > > > really want to go down this path? > > > > No, we don't, if you want to have patches be able to apply properly to > > older kernels, as you point out. > > git-apply --ignore-whitespace ? Doesn't work with my code-flow for handling stable patches, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists