lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 23 Oct 2014 01:47:37 +0200
From:	Hartmut Knaack <knaack.h@....de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Brian Vandre <bvandre@...il.com>
CC:	gregkh@...uxfoundation.org, jic23@...nel.org,
	alexandre.belloni@...e-electrons.com, linux-iio@...r.kernel.org,
	marex@...x.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters

Sudip Mukherjee schrieb am 22.10.2014 06:21:
> On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
>> This fixes the 2 checkpatch.pl warnings:
>> WARNING: line over 80 characters
>>
> please check your patch with --strict option of checkpatch.pl , and you will get :
> "Alignment should match open parenthesis" .
> 
Good point, but what solution would you propose?
> thanks
> sudip
> 
>> Signed-off-by: Brian Vandre <bvandre@...il.com>
>> ---
>>  drivers/staging/iio/adc/mxs-lradc.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
>> index 32a1926..62449a6 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -455,7 +455,8 @@ static void mxs_lradc_setup_ts_channel(struct mxs_lradc *lradc, unsigned ch)
>>  	 * SoC's delay unit and start the conversion later
>>  	 * and automatically.
>>  	 */
>> -	mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
>> +	mxs_lradc_reg_wrt(lradc,
>> +		LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
>>  		LRADC_DELAY_TRIGGER_DELAYS(1 << 3) | /* trigger DELAY unit#3 */
>>  		LRADC_DELAY_KICK |
>>  		LRADC_DELAY_DELAY(lradc->settling_delay),
>> @@ -513,7 +514,8 @@ static void mxs_lradc_setup_ts_pressure(struct mxs_lradc *lradc, unsigned ch1,
>>  	 * SoC's delay unit and start the conversion later
>>  	 * and automatically.
>>  	 */
>> -	mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
>> +	mxs_lradc_reg_wrt(lradc,
>> +		LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
>>  		LRADC_DELAY_TRIGGER_DELAYS(1 << 3) | /* trigger DELAY unit#3 */
>>  		LRADC_DELAY_KICK |
>>  		LRADC_DELAY_DELAY(lradc->settling_delay), LRADC_DELAY(2));
>> -- 
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists