lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Oct 2014 21:11:15 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Michal Marek <mmarek@...e.cz> Cc: LKML <linux-kernel@...r.kernel.org>, Masahiro Yamada <yamada.m@...panasonic.com>, Peter Foley <pefoley2@...oley.com>, linux-kbuild@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [PATCH] kbuild: Fix output of make kernelrelease On Wed, 22 Oct 2014 21:44:08 +0200 Michal Marek <mmarek@...e.cz> wrote: > Dne 22.10.2014 v 16:19 Steven Rostedt napsal(a): > > > > Commit 7ff525712acf "kbuild: fake the "Entering directory ..." message > > more simply" changed the output of "make kernelrelease" such that the > > kernel release version was not the last line printed. This broke various > > tools that would find the kernel release with "make kernelrelease | tail -1". > > The cleaner and recommended (see recent make help) way is to use make -s: > > $ make O=build -s kernelrelease > 3.18.0-rc1+ > > no further processing is needed. I don't mind changing my script with your patch. But this does break other scripts of mine that I need to hunt down and change. My fear is why do we need the '-s' when there may be other methods to preserve the old functionality. If this is breaking my scripts, I wonder if it is also breaking other scripts out there too? As you stated, it wasn't until recently that the help message recommended the '-s'. -- Steve > > > > One of those tools that broke was ktest.pl which resides in the kernel. > > Can you please apply this patch? > > Thanks, > Michal > > >From c660b235e25eee053337e0e6c952e87f39839c63 Mon Sep 17 00:00:00 2001 > From: Michal Marek <mmarek@...e.cz> > Date: Wed, 22 Oct 2014 21:25:39 +0200 > Subject: [PATCH] ktest: Use make -s kernelrelease > > The previous tail -1 broke with commit 7ff525712acf ("kbuild: fake the > "Entering directory ..." message more simply") > > Reported-by: Steven Rostedt <rostedt@...dmis.org> > Signed-off-by: Michal Marek <mmarek@...e.cz> > --- > tools/testing/ktest/ktest.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl > index bf13981..60fe020 100755 > --- a/tools/testing/ktest/ktest.pl > +++ b/tools/testing/ktest/ktest.pl > @@ -2005,7 +2005,7 @@ sub get_version { > # get the release name > return if ($have_version); > doprint "$make kernelrelease ... "; > - $version = `$make kernelrelease | tail -1`; > + $version = `$make -s kernelrelease`; > chomp($version); > doprint "$version\n"; > $have_version = 1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists