lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Oct 2014 17:09:44 -0700 From: Doug Anderson <dianders@...omium.org> To: Chris Zhong <zyw@...k-chips.com> Cc: Heiko Stuebner <heiko@...ech.de>, Mike Turquette <mturquette@...aro.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, linux-rockchip@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Linus Walleij <linus.walleij@...aro.org>, Tony Xie <xxx@...k-chips.com> Subject: Re: [PATCH v4 5/6] ARM: rockchip: Add pmu-sram binding Chris, On Tue, Oct 21, 2014 at 4:26 PM, Chris Zhong <zyw@...k-chips.com> wrote: > The pmu-sram is used to store resume code, suspend/resume need get the > address of it. Therefore add a binding and documentation for it. > > Signed-off-by: Tony Xie <xxx@...k-chips.com> > Signed-off-by: Chris Zhong <zyw@...k-chips.com> > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/arm/rockchip/pmu-sram.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt > > diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt b/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt > new file mode 100644 > index 0000000..77284c0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt > @@ -0,0 +1,15 @@ > +Rockchip SRAM for pmu: > +------------------------------ > + > +The sram of pmu is used to store the function of resume from maskrom(the 1st > +level loader). It's probably best in this document to say that this is a common use of the "pmu-sram" because it keeps power even in low power states in the system. ...this SRAM could be used for other things as well. > +Required node properties: > +- compatible : should be "rockchip,rk3288-pmu-sram" > +- reg : physical base address and the size of the registers window > + > +Example: > + pmu_intmem@...20000 { > + compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; > + reg = <0xff720000 0x4000>; As with the other patch, should probably change the size in the example to 0x1000 (4K). Otherwise this looks good to me. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists