linux-kernel - Re: [PATCH v2 2/2] staging: skein: Add Loadable Module Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141023123351.GQ23154@mwanda>
Date:	Thu, 23 Oct 2014 15:33:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Eric Rost <eric.rost@...abylon.net>
Cc:	gregkh@...uxfoundation.org, jason@...edaemon.net, jake@....net,
	antonysaraev@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] staging: skein: Add Loadable Module Support

On Wed, Oct 22, 2014 at 09:24:37PM -0500, Eric Rost wrote:
> +static int __init skein_generic_mod_init(void)
> +{
> +	return crypto_register_shash(&alg256) || crypto_register_shash(&alg512)
> +		|| crypto_register_shash(&alg1024);

Shouldn't it unwind on error?

> +}

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/