| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141023124243.GA10433@brian-U> Date: Thu, 23 Oct 2014 07:42:43 -0500 From: Brian Vandre <bvandre@...il.com> To: Lars-Peter Clausen <lars@...afoo.de> Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>, gregkh@...uxfoundation.org, jic23@...nel.org, alexandre.belloni@...e-electrons.com, linux-iio@...r.kernel.org, marex@...x.de, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters On Thu, Oct 23, 2014 at 12:50:00PM +0200, Lars-Peter Clausen wrote: > On 10/22/2014 06:21 AM, Sudip Mukherjee wrote: > >On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote: > >>This fixes the 2 checkpatch.pl warnings: > >>WARNING: line over 80 characters > >> > >please check your patch with --strict option of checkpatch.pl , and you will get : > >"Alignment should match open parenthesis" . > > Those checkpatch warnings are suggestions, not hard requirements. > The idea is to improve code legibility, but if the change has the > adverse effect the warning can and should be ignored. Also when > making a change you should keep the existing indention style of a > file. > > - Lars I think my patch does follow the style of the original file. If you run checkpatch.pl --strict on the whole file you will get many open parenthesis warnings. I believe it does make it slightly more legibile. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists