lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Oct 2014 10:09:36 -0600 From: Jens Axboe <axboe@...nel.dk> To: Sudip Mukherjee <sudipm.mukherjee@...il.com> CC: linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] block: wrong return value On 10/23/2014 10:04 AM, Sudip Mukherjee wrote: > while compiling integer err was showing as a set but unused variable. > elevator_init_fn can be either cfq_init_queue or deadline_init_queue > or noop_init_queue. > all three of these functions are returning -ENOMEM if they fail to > allocate the queue. > so we should actually be returning the error code rather than > returning 0 always. > > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org> > --- > > change in v2: added elevator_put > > block/elevator.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/block/elevator.c b/block/elevator.c > index 24c28b6..1267c2b 100644 > --- a/block/elevator.c > +++ b/block/elevator.c > @@ -184,7 +184,7 @@ static void elevator_release(struct kobject *kobj) > int elevator_init(struct request_queue *q, char *name) > { > struct elevator_type *e = NULL; > - int err; > + int err = 0; Why init it to 0? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists