lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Oct 2014 18:26:33 +0200 From: Heiko Stübner <heiko@...ech.de> To: Doug Anderson <dianders@...omium.org> Cc: Linus Walleij <linus.walleij@...aro.org>, Chris Zhong <zyw@...k-chips.com>, Sonny Rao <sonnyrao@...omium.org>, linux-rockchip@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 3/4] pinctrl: rockchip: Parse pin groups before calling pinctrl_register() Am Dienstag, 21. Oktober 2014, 10:47:34 schrieb Doug Anderson: > Just like in (529301c pinctrl: samsung: Parse pin groups before > calling pinctrl_register()), Rockchip also needs to parse pin groups > earlier to make hogs work. > > Signed-off-by: Doug Anderson <dianders@...omium.org> > Tested-by: Chris Zhong <zyw@...k-chips.com> Reviewed-by: Heiko Stuebner <heiko@...ech.de> > --- > Changes in v2: None > > drivers/pinctrl/pinctrl-rockchip.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c > b/drivers/pinctrl/pinctrl-rockchip.c index 8a3c582..6c14f6c 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -1262,6 +1262,10 @@ static int rockchip_pinctrl_register(struct > platform_device *pdev, } > } > > + ret = rockchip_pinctrl_parse_dt(pdev, info); > + if (ret) > + return ret; > + > info->pctl_dev = pinctrl_register(ctrldesc, &pdev->dev, info); > if (!info->pctl_dev) { > dev_err(&pdev->dev, "could not register pinctrl driver\n"); > @@ -1279,12 +1283,6 @@ static int rockchip_pinctrl_register(struct > platform_device *pdev, pinctrl_add_gpio_range(info->pctl_dev, > &pin_bank->grange); > } > > - ret = rockchip_pinctrl_parse_dt(pdev, info); > - if (ret) { > - pinctrl_unregister(info->pctl_dev); > - return ret; > - } > - > return 0; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists