lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 23 Oct 2014 20:25:35 +0400
From:	Ilya Dryomov <ilya.dryomov@...tank.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Sage Weil <sage@...tank.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ceph Development <ceph-devel@...r.kernel.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply()

On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick <fabf@...net.be> wrote:
> osdmap_epoch is redundant with reassert_epoch and unused.
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  net/ceph/osd_client.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index f3fc54e..432bd75 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -1700,7 +1700,6 @@ static void handle_reply(struct ceph_osd_client *osdc, struct ceph_msg *msg,
>         int err;
>         u32 reassert_epoch;
>         u64 reassert_version;
> -       u32 osdmap_epoch;
>         int already_completed;
>         u32 bytes;
>         unsigned int i;
> @@ -1725,7 +1724,6 @@ static void handle_reply(struct ceph_osd_client *osdc, struct ceph_msg *msg,
>         result = ceph_decode_32(&p);
>         reassert_epoch = ceph_decode_32(&p);
>         reassert_version = ceph_decode_64(&p);
> -       osdmap_epoch = ceph_decode_32(&p);
>
>         /* lookup */
>         down_read(&osdc->map_sem);

Hi Fabian,

osdmap_epoch is useful for debugging, but this is wrong anyway -
ceph_decode_32() has side effects.  Removing it and not adjusting *p
would make the whole thing blow up pretty fast..

Thanks,

                Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists