linux-kernel - [PATCH 1/1 linux-next] bsg: fix shadow warning in bsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 23 Oct 2014 18:53:47 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	linux-kernel@...r.kernel.org
Cc:	Fabian Frederick <fabf@...net.be>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Jens Axboe <axboe@...nel.dk>, linux-scsi@...r.kernel.org
Subject: [PATCH 1/1 linux-next] bsg: fix shadow warning in bsg_ioctl()

directly call scsi_cmd_ioctl() with (void __user *)arg instead
of uarg redeclaration.

Signed-off-by: Fabian Frederick <fabf@...net.be>
---
 block/bsg.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/block/bsg.c b/block/bsg.c
index 276e869..c2f90bd 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -921,10 +921,9 @@ static long bsg_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case SG_GET_RESERVED_SIZE:
 	case SG_SET_RESERVED_SIZE:
 	case SG_EMULATED_HOST:
-	case SCSI_IOCTL_SEND_COMMAND: {
-		void __user *uarg = (void __user *) arg;
-		return scsi_cmd_ioctl(bd->queue, NULL, file->f_mode, cmd, uarg);
-	}
+	case SCSI_IOCTL_SEND_COMMAND:
+		return scsi_cmd_ioctl(bd->queue, NULL, file->f_mode, cmd,
+				      (void __user *)arg);
 	case SG_IO: {
 		struct request *rq;
 		struct bio *bio, *bidi_bio = NULL;
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/