linux-kernel - Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1414084222.17121.30.camel@x220>
Date:	Thu, 23 Oct 2014 19:10:22 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Dinh Nguyen <dinguyen@...nsource.altera.com>
Cc:	paulz@...opsys.com, balbi@...com, dinh.linux@...il.com,
	linux-kernel@...r.kernel.org, swarren@...dotorg.org,
	b.zolnierkie@...sung.com, matthijs@...in.nl, r.baldyga@...sung.com,
	jg1.han@...sung.com, sachin.kamat@...aro.org, ben-linux@...ff.org,
	dianders@...omium.org, kever.yang@...k-chips.com,
	linux-usb@...r.kernel.org
Subject: Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

On Thu, 2014-10-23 at 10:05 -0500, Dinh Nguyen wrote:
> On 10/22/2014 03:27 PM, Paul Bolle wrote:
> > On Tue, 2014-10-21 at 15:47 -0500, Dinh Nguyen wrote:
> Well, CONFIG_USB enables the host stack that is needed by the DWC2
> driver, without CONFIG_USB, the DWC2 driver will not be able to build.
>
> >> In addition, thanks to your comment, I realized that DWC2 should also be
> >> available to build when USB_GADGET is enabled. A patch has been sent:
> >>
> >> http://marc.info/?l=linux-usb&m=141392377124818&w=2

Doesn't that patch contradict your statement? It allows USB_DWC2 to be
set even if USB is not set.

> > I haven't checked, but doesn't this mean USB_DWC2 could just depend on
> > USB_SUPPORT?
> > 
> I don't think so because USB_SUPPORT will not select USB or USB_GAGDGET,
> and the DWC2 driver will need either 1 or both for it to build correctly.

My comment was not well thought through. It was a waste of your time.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/