linux-kernel - Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54494861.80102@opensource.altera.com>
Date:	Thu, 23 Oct 2014 13:26:41 -0500
From:	Dinh Nguyen <dinguyen@...nsource.altera.com>
To:	Paul Zimmerman <Paul.Zimmerman@...opsys.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
CC:	"balbi@...com" <balbi@...com>,
	"dinh.linux@...il.com" <dinh.linux@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"matthijs@...in.nl" <matthijs@...in.nl>,
	"r.baldyga@...sung.com" <r.baldyga@...sung.com>,
	"jg1.han@...sung.com" <jg1.han@...sung.com>,
	"sachin.kamat@...aro.org" <sachin.kamat@...aro.org>,
	"ben-linux@...ff.org" <ben-linux@...ff.org>,
	"dianders@...omium.org" <dianders@...omium.org>,
	"kever.yang@...k-chips.com" <kever.yang@...k-chips.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

On 10/23/2014 01:28 PM, Paul Zimmerman wrote:
>> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@...sung.com]
>> Sent: Wednesday, October 22, 2014 5:26 AM
>>
>> On Monday, October 20, 2014 01:52:06 PM dinguyen@...nsource.altera.com wrote:
>>> From: Dinh Nguyen <dinguyen@...nsource.altera.com>
>>>
>>>  config USB_DWC2_PLATFORM
>>>  	bool "DWC2 Platform"
>>> -	depends on USB_DWC2_HOST
>>>  	default USB_DWC2_HOST
>>
>> It should be "default USB_DWC2_HOST || USB_DWC2_PERIPHERAL" because
>> USB_DWC2_PLATFORM replaces current USB_DWC2_PERIPHERAL functionality.
>>
>> Additionaly USB_DWC2_PLATFORM should be changed to tristate
>> (USB_DWC2_PERIPHERAL was a tristeate before your changes).
> 
> Dinh, I think this is a good point. Is there any reason why
> USB_DWC2_PLATFORM (and USB_DWC2_PCI for that matter) can't be
> tristate? That's what DWC3 does.
> 

Yes, in my v6, I have made this change.

Thanks,
Dinh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/