linux-kernel - Re: [PATCH 2/4] Add pgcollapse controls to task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141023193706.GB6751@redhat.com>
Date:	Thu, 23 Oct 2014 21:37:06 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Alex Thorlton <athorlton@....com>
Cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Bob Liu <lliubbo@...il.com>,
	David Rientjes <rientjes@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Hugh Dickins <hughd@...gle.com>,
	Ingo Molnar <mingo@...hat.com>,
	Kees Cook <keescook@...omium.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Mel Gorman <mgorman@...e.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Rik van Riel <riel@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Vladimir Davydov <vdavydov@...allels.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Add pgcollapse controls to task_struct

On 10/23, Alex Thorlton wrote:
>
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1661,6 +1661,18 @@ struct task_struct {
>  	unsigned int	sequential_io;
>  	unsigned int	sequential_io_avg;
>  #endif
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +	struct callback_head pgcollapse_work;
> +	/* default scan 8*512 pte (or vmas) every 30 second */
> +	unsigned int pgcollapse_pages_to_scan;
> +	unsigned int pgcollapse_pages_collapsed;
> +	unsigned int pgcollapse_full_scans;
> +	unsigned int pgcollapse_scan_sleep_millisecs;
> +	/* during fragmentation poll the hugepage allocator once every minute */
> +	unsigned int pgcollapse_alloc_sleep_millisecs;
> +	unsigned long pgcollapse_last_scan;
> +	unsigned long pgcollapse_scan_address;
> +#endif

Shouldn't this all live in mm_struct?

Except pgcollapse_work can't, exit_mm() called before exit_mm(). Probably
it can be allocated.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/