linux-kernel - Re: [patch] regulator: max77802: precedence error in max77802_set_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <71442C69-B48C-46B8-93A1-068AC26E01C2@collabora.co.uk>
Date:	Fri, 24 Oct 2014 11:04:28 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] regulator: max77802: precedence error in max77802_set_suspend_mode()

Hello Dan,

> On 24/10/2014, at 10:16, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> The "!" operation has higher precedence that the comparison.
> 
> Fixes: 2e0eaa1aa008 ('regulator: max77802: Add set suspend mode for BUCKs and simplify code')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c
> index 5839c45..57e37fd 100644
> --- a/drivers/regulator/max77802.c
> +++ b/drivers/regulator/max77802.c
> @@ -179,7 +179,7 @@ static int max77802_set_suspend_mode(struct regulator_dev *rdev,
>     * If the regulator has been disabled for suspend
>     * then is invalid to try setting a suspend mode.
>     */
> -    if (!max77802->opmode[id] == MAX77802_OFF_PWRREQ) {
> +    if (max77802->opmode[id] != MAX77802_OFF_PWRREQ) {
>        dev_warn(&rdev->dev, "%s: is disabled, mode: 0x%x not set\n",
>             rdev->desc->name, mode);
>        return 0;

Thanks for the patch, there is indeed a typo error but $subject is not the correct fix.

The problem is that the "!" operator should not be in the expression so it has be removed and only compare if opmode is equal to MAX72802_OFF_PWRREQ.

With that change feel free to add my Reviewed-by.

Best regards,
Javier--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/