linux-kernel - Re: [PATCH v2 08/47] kernel: Move pm_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <544A2017.7020804@imgtec.com>
Date:	Fri, 24 Oct 2014 10:47:03 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Guenter Roeck <linux@...ck-us.net>, <linux-kernel@...r.kernel.org>
CC:	<linux-pm@...r.kernel.org>,
	<adi-buildroot-devel@...ts.sourceforge.net>, <linux390@...ibm.com>,
	<linux-alpha@...r.kernel.org>, <linux-am33-list@...hat.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-c6x-dev@...ux-c6x.org>, <linux-cris-kernel@...s.com>,
	<linux-hexagon@...r.kernel.org>, <linux-ia64@...r.kernel.org>,
	<linux@...nrisc.net>, <linux-m68k@...r.kernel.org>,
	<linux-metag@...r.kernel.org>, <linux-mips@...ux-mips.org>,
	<linux-parisc@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-s390@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<linux-xtensa@...ux-xtensa.org>, <sparclinux@...r.kernel.org>,
	<user-mode-linux-devel@...ts.sourceforge.net>,
	<user-mode-linux-user@...ts.sourceforge.net>, <x86@...nel.org>,
	<xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH v2 08/47] kernel: Move pm_power_off to common code

Hi Guenter,

On 21/10/14 05:12, Guenter Roeck wrote:
> pm_power_off is defined for all architectures. Move it to common code.
> 
> Have all architectures call do_kernel_power_off instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_kernel_power_off from machine_power_off instead.
> 
> Acked-by: David Vrabel <david.vrabel@...rix.com>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Acked-by: Hirokazu Takata <takata@...ux-m32r.org>
> Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>
> Acked-by: Max Filippov <jcmvbkbc@...il.com>
> Acked-by: Rafael J. Wysocki <rjw@...ysocki.net>
> Acked-by: Richard Weinberger <richard@....at>
> Acked-by: Xuetao Guan <gxt@...c.pku.edu.cn>

For metag:
Acked-by: James Hogan <james.hogan@...tec.com>

Thanks
James

> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 483dff9..8d95773 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -67,9 +67,6 @@ void arch_cpu_idle_dead(void)
>  }
>  #endif
>  
> -void (*pm_power_off)(void);
> -EXPORT_SYMBOL(pm_power_off);
> -
>  void (*soc_restart)(char *cmd);
>  void (*soc_halt)(void);
>  
> @@ -90,8 +87,7 @@ void machine_halt(void)
>  
>  void machine_power_off(void)
>  {
> -	if (pm_power_off)
> -		pm_power_off();
> +	do_kernel_power_off();
>  	smp_send_stop();
>  	hard_processor_halt(HALT_OK);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/