linux-kernel - Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141024103939.GD2910@bark>
Date:	Fri, 24 Oct 2014 11:39:39 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jani Nikula <jani.nikula@...el.com>,
	Kees Cook <keescook@...omium.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: fix use via symlink, make missing spelling
 file non-fatal

On Fri, Oct 24, 2014 at 02:31:50AM -0700, Joe Perches wrote:
> On Fri, 2014-10-24 at 10:02 +0100, Andy Whitcroft wrote:
> > On Thu, Oct 23, 2014 at 10:29:11AM -0700, Joe Perches wrote:
> > 
> > [...]
> > >  my $P = $0;
> > > -$P =~ s@(.*)/@@g;
> > > -my $D = $1;
> > > +my $D = dirname(abs_path($P));
> > 
> > That changes the value of $P, I don't know if that is intended:
> > 
> >   my $D = dirname(abs_path($0));
> > 
> > or
> > 
> >   my $D = abs_path($1);
> > 
> > perhaps to keep $P as it was.
> 
> I did it to show the executable passed on the cmdline better.
> 
> It changes --help and some warn/die messages.
> 
> It's not particularly important either way.

If it was intended then great.  Either way is fine with me.

Acked-by: Andy Whitcroft <apw@...onical.com>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/