linux-kernel - Re: [PATCH 2/4] ARM: mvebu: Move SCU power up in a function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141024141958.319af5d3@free-electrons.com>
Date:	Fri, 24 Oct 2014 14:19:58 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc:	Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org,
	Lior Amsalem <alior@...vell.com>,
	Tawfik Bayouk <tawfik@...vell.com>,
	Nadav Haklai <nadavh@...vell.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: mvebu: Move SCU power up in a function

Dear Gregory CLEMENT,

On Fri, 24 Oct 2014 14:11:17 +0200, Gregory CLEMENT wrote:

> > Since this function is not static, I think it might be a good idea to
> > use a prefix that makes it more specific to the platform in order to
> > not pollute the global namespace. Maybe something like
> > 'armada_38x_scu_power_up', or something like that.
> 
> Yes given the fact that this function is declared in the mach-mveu folder
> it is sensible to use a more specific name. However the function itself
> is not specific at all to an SoC. This function could be used for any Cortex A9
> using the SCU.

Indeed, but as you say, it's right now defined in the mvebu specific
code, so we shouldn't pollute the global namespace.

Note that there is already a scu_power_mode() that does the same thing,
but implemented in C, so I'm not sure you can call it at search an early
point.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/