linux-kernel - Re: [PATCH v13 3/5] ARM: dts: add RK3288 Thermal data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5449B72B.5090005@rock-chips.com>
Date:	Fri, 24 Oct 2014 10:19:23 +0800
From:	Caesar Wang <caesar.wang@...k-chips.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	heiko@...ech.de, rui.zhang@...el.com, edubezval@...il.com,
	zyf@...k-chips.com, dianders@...omium.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	cf@...k-chips.com, dbasehore@...omium.org, huangtao@...k-chips.com,
	cjf@...k-chips.com, zhengsq@...k-chips.com
Subject: Re: [PATCH v13 3/5] ARM: dts: add RK3288 Thermal data

Dmitry,

在 2014/10/24 8:48, Dmitry Torokhov 写道:
> Hi Caesar,
>
> On Thu, Oct 23, 2014 at 05:40:05PM +0800, Caesar Wang wrote:
>> This patch changes a dtsi file to contain the thermal data
>> on RK3288 and later SoCs. This data will
>> enable a thermal shutdown over 125C.
>>
>> Signed-off-by: Caesar Wang <caesar.wang@...k-chips.com>
>> ---
>>   arch/arm/boot/dts/rk3288-thermal.dtsi | 65 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 65 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/rk3288-thermal.dtsi
>>
>> diff --git a/arch/arm/boot/dts/rk3288-thermal.dtsi b/arch/arm/boot/dts/rk3288-thermal.dtsi
>> new file mode 100644
>> index 0000000..c361262
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/rk3288-thermal.dtsi
>> @@ -0,0 +1,65 @@
>> +/*
>> + * Device Tree Source for RK3288 SoC thermal
>> + *
>> + * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2.  This program is licensed "as is" without any warranty of any
>> + * kind, whether express or implied.
>> + */
>> +
>> +#include <dt-bindings/thermal/thermal.h>
>> +
>> +reserve_thermal: reserve_thermal {
>> +	polling-delay-passive = <500>; /* milliseconds */
>> +	polling-delay = <1000>; /* milliseconds */
>> +
>> +			/* sensor	ID */
>> +	thermal-sensors = <&tsadc	0>;
>> +
>> +};
>> +
>> +cpu_thermal: cpu_thermal {
>> +	polling-delay-passive = <500>; /* milliseconds */
>> +	polling-delay = <1000>; /* milliseconds */
> Given that the hardware supports alarm interrupts I think we should be
> able to lower polling frequency. I'd say 5 seconds for polling-delay and
> 1 second for when we trip over passive point?
As you say:

+cpu_thermal: cpu_thermal {
+	polling-delay-passive = <1000>; /* milliseconds */
+	polling-delay = <5000>; /* milliseconds */

I think it's ok for me if the driver follow your change.


>
> Thanks.
>

-- 
Best regards,
Caesar


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/