linux-kernel - Re: [PATCH] vdso: don't require 64-bit math in standalone test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <544AA4BA.2040106@infradead.org>
Date:	Fri, 24 Oct 2014 12:12:58 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Jeff Mahoney <jeffm@...e.com>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Peter Foley <pefoley2@...oley.com>,
	Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] vdso: don't require 64-bit math in standalone test

On 10/24/14 11:48, Jeff Mahoney wrote:
> The use of 64-bit math on i386 causes build failures:
> vdso_standalone_test_x86.c:(.text+0x101): undefined reference to `__umoddi3'
> vdso_standalone_test_x86.c:(.text+0x12d): undefined reference to `__udivdi3'
> 
> Commit adb19fb66ee (Documentation: add makefiles for more targets) is
> now building this by default, so it's failing the kernel build entirely.
> 
> Switching the declaration from uint64_t to time_t does the right thing
> and handles the x32 case automatically.
> 
> Signed-off-by: Jeff Mahoney <jeffm@...e.com>

Jon, please pick this up.  It was
Acked-by: Peter Foley <pefoley2@...oley.com>

> ---
>  Documentation/vDSO/vdso_standalone_test_x86.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/Documentation/vDSO/vdso_standalone_test_x86.c
> +++ b/Documentation/vDSO/vdso_standalone_test_x86.c
> @@ -63,7 +63,7 @@ static inline void linux_exit(int code)
>  	x86_syscall3(__NR_exit, code, 0, 0);
>  }
>  
> -void to_base10(char *lastdig, uint64_t n)
> +void to_base10(char *lastdig, time_t n)
>  {
>  	while (n) {
>  		*lastdig = (n % 10) + '0';
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/