linux-kernel - Re: [PATCH] iio: tsl4531: Fix compiler error when CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <544B7290.1030102@kernel.org>
Date:	Sat, 25 Oct 2014 10:51:12 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Dan Murphy <dmurphy@...com>, pmeerw@...erw.net
CC:	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: tsl4531: Fix compiler error when CONFIG_PM_OPS is
 not defined

On 20/10/14 20:52, Dan Murphy wrote:
> Fix the compiler error when the CONFIG_PM_OPS flag is not set.
> 
> drivers/iio/light/tsl4531.c:235:8: error: ‘tsl4531_suspend’ undeclared here (not in a function)
> drivers/iio/light/tsl4531.c:235:8: error: ‘tsl4531_resume’ undeclared here (not in a function)
> 
> Signed-off-by: Dan Murphy <dmurphy@...com>
Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan
> ---
>  drivers/iio/light/tsl4531.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/tsl4531.c b/drivers/iio/light/tsl4531.c
> index a15006e..0763b86 100644
> --- a/drivers/iio/light/tsl4531.c
> +++ b/drivers/iio/light/tsl4531.c
> @@ -230,9 +230,12 @@ static int tsl4531_resume(struct device *dev)
>  	return i2c_smbus_write_byte_data(to_i2c_client(dev), TSL4531_CONTROL,
>  		TSL4531_MODE_NORMAL);
>  }
> -#endif
>  
>  static SIMPLE_DEV_PM_OPS(tsl4531_pm_ops, tsl4531_suspend, tsl4531_resume);
> +#define TSL4531_PM_OPS (&tsl4531_pm_ops)
> +#else
> +#define TSL4531_PM_OPS NULL
> +#endif
>  
>  static const struct i2c_device_id tsl4531_id[] = {
>  	{ "tsl4531", 0 },
> @@ -243,7 +246,7 @@ MODULE_DEVICE_TABLE(i2c, tsl4531_id);
>  static struct i2c_driver tsl4531_driver = {
>  	.driver = {
>  		.name   = TSL4531_DRV_NAME,
> -		.pm	= &tsl4531_pm_ops,
> +		.pm	= TSL4531_PM_OPS,
>  		.owner  = THIS_MODULE,
>  	},
>  	.probe  = tsl4531_probe,
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/