lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Oct 2014 19:38:27 +0100 From: Sam Ravnborg <sam@...nborg.org> To: Andy Lutomirski <luto@...capital.net> Cc: Richard Weinberger <richard.weinberger@...il.com>, linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, linux-arch <linux-arch@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>, hpa@...or.com Subject: Re: [PATCH] all arches, signal: Move restart_block to struct task_struct sparc/include/asm/thread_info_32.h b/arch/sparc/include/asm/thread_info_32.h > index 025c98446b1e..88719dbb12f5 100644 > --- a/arch/sparc/include/asm/thread_info_32.h > +++ b/arch/sparc/include/asm/thread_info_32.h > @@ -62,9 +62,6 @@ struct thread_info { > .flags = 0, \ > .cpu = 0, \ > .preempt_count = INIT_PREEMPT_COUNT, \ > - .restart_block = { \ > - .fn = do_no_restart_syscall, \ > - }, \ > } If this is deleted then the corresponding TI_RESTART_BLOCK should go as well > > #define init_thread_info (init_thread_union.thread_info) > diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h > index 798f0279a4b5..a11f1e551a58 100644 > --- a/arch/sparc/include/asm/thread_info_64.h > +++ b/arch/sparc/include/asm/thread_info_64.h > @@ -124,9 +124,6 @@ struct thread_info { > .current_ds = ASI_P, \ > .exec_domain = &default_exec_domain, \ > .preempt_count = INIT_PREEMPT_COUNT, \ > - .restart_block = { \ > - .fn = do_no_restart_syscall, \ > - }, \ > } When thread_info is modified the relevant TI_ constants needs to be updated. And TI_RESTART_BLOCK shold be killed as it is no longer relevant. This stuff is caught only at run-time - and not at build time which would have been better. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists