linux-kernel - Re: [PATCH v2] futex: fix a race condition between REQUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Oct 2014 15:45:37 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Brian Silverman <bsilver16384@...il.com>
cc:	austin.linux@...il.com, linux-kernel@...r.kernel.org,
	darren@...art.com, peterz@...radead.org
Subject: Re: [PATCH v2] futex: fix a race condition between REQUEUE_PI and
 task death

On Sat, 25 Oct 2014, Brian Silverman wrote:
> @@ -1558,6 +1558,12 @@ retry_private:
>  		ret = get_futex_value_locked(&curval, uaddr1);
>  
>  		if (unlikely(ret)) {
> +			/*
> +			 * We will have to lookup the pi_state again, so
> +			 * free this one to keep the accounting correct.
> +			 */
> +			free_pi_state(pi_state, hb2);
> +			pi_state = NULL;

pi_state is always NULL here. No point for this call.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/