linux-kernel - Re: [PATCH] sched:skip loop non-idle cpus after find an idle cpu while find_idlest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141027092317.GC10867@linux.vnet.ibm.com>
Date:	Mon, 27 Oct 2014 14:53:17 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Yao Dongdong <yaodongdong@...wei.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched:skip loop non-idle cpus after find an idle cpu
 while find_idlest_cpu

* Yao Dongdong <yaodongdong@...wei.com> [2014-10-27 16:58:05]:

> On 2014/10/27 16:04, Srikar Dronamraju wrote:
> > * Yao Dongdong <yaodongdong@...wei.com> [2014-10-27 11:13:17]:
> >
> >> Idle cpu is idler than non-idle cpu, so we needn't loop non-idle cpus after find an idle cpu.
> >>
> > While this check looks good,
> > I dont see how we are avoiding a loop?
> >
> > Are you suggesting that we break of the for loop once we set
> > shallowest_idle_cpu?
> >
> Thanks for your review.
> 
> I agree that the submit message is a bit misleading, what this patch do is just avoiding search for least_loaded_cpu
> in non-idle cpus.
> 
>     sched:add check of shallowest_idle_cpu before search for least_loaded_cpu
> 
>     Idle cpu is idler than non-idle cpu, so we needn't search for least_loaded_cpu
>     after we have found an idle cpu.
> 

Looks good for me.

Reviewed-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>


-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/