linux-kernel - Re: [PATCH v8 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Oct 2014 14:42:57 +0200
From:	Octavian Purdila <octavian.purdila@...el.com>
To:	Johan Hovold <johan@...nel.org>
Cc:	Octavian Purdila <octavian.purdila@...el.com>,
	Greg KH <gregkh@...uxfoundation.org>, linus.walleij@...aro.org,
	gnurou@...il.com, wsa@...-dreams.de, sameo@...ux.intel.com,
	lee.jones@...aro.org, Arnd Bergmann <arnd@...db.de>,
	Daniel Baluta <daniel.baluta@...el.com>,
	Laurentiu Palcu <laurentiu.palcu@...el.com>,
	linux-usb@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v8 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

On Thu, Oct 23, 2014 at 6:19 PM, Johan Hovold <johan@...nel.org> wrote:
>
> On Wed, Oct 15, 2014 at 05:48:09PM +0300, Octavian Purdila wrote:
>
> > +static int dln2_i2c_xfer(struct i2c_adapter *adapter,
> > +                      struct i2c_msg *msgs, int num)
> > +{
> > +     struct dln2_i2c *dln2 = i2c_get_adapdata(adapter);
> > +     struct i2c_msg *pmsg;
> > +     struct device *dev = &dln2->pdev->dev;
>
> You want to use the i2c-adapter device here (not the platform device).
>

You are right, I will fix in v9.

> > +     int i;
> > +
> > +     for (i = 0; i < num; i++) {
> > +             int ret;
> > +
> > +             pmsg = &msgs[i];
> > +
> > +             if (pmsg->len > DLN2_I2C_MAX_XFER_SIZE) {
> > +                     dev_warn(dev, "maximum transfer size exceeded\n");
> > +                     return -EOPNOTSUPP;
> > +             }
> > +
> > +             if (pmsg->flags & I2C_M_RD) {
> > +                     ret = dln2_i2c_read(dln2, pmsg->addr, pmsg->buf,
> > +                                         pmsg->len);
> > +                     if (ret < 0)
> > +                             return ret;
> > +
> > +                     pmsg->len = ret;
> > +             } else {
> > +                     ret = dln2_i2c_write(dln2, pmsg->addr, pmsg->buf,
> > +                                          pmsg->len);
> > +                     if (ret != pmsg->len)
> > +                             return -EPROTO;
> > +             }
> > +     }
> > +
> > +     return num;
> > +}
>
> [...]
>
> > +static int dln2_i2c_probe(struct platform_device *pdev)
> > +{
> > +     int ret;
> > +     struct dln2_i2c *dln2;
> > +     struct device *dev = &pdev->dev;
> > +     struct dln2_platform_data *pdata = dev_get_platdata(&pdev->dev);
> > +
> > +     dln2 = devm_kzalloc(dev, sizeof(*dln2), GFP_KERNEL);
> > +     if (!dln2)
> > +             return -ENOMEM;
> > +
> > +     dln2->buf = devm_kmalloc(dev, DLN2_I2C_BUF_SIZE, GFP_KERNEL);
> > +     if (!dln2->buf)
> > +             return -ENOMEM;
> > +
> > +     dln2->pdev = pdev;
> > +     dln2->port = pdata->port;
> > +
> > +     /* setup i2c adapter description */
> > +     dln2->adapter.owner = THIS_MODULE;
> > +     dln2->adapter.class = I2C_CLASS_HWMON;
> > +     dln2->adapter.algo = &dln2_i2c_usb_algorithm;
> > +     dln2->adapter.dev.parent = dev;
> > +     i2c_set_adapdata(&dln2->adapter, dln2);
> > +     snprintf(dln2->adapter.name, sizeof(dln2->adapter.name), "%s-%s-%d",
> > +              "dln2-i2c", dev_name(pdev->dev.parent), dln2->port);
> > +
> > +     platform_set_drvdata(pdev, dln2);
> > +
> > +     /* initialize the i2c interface */
>
> No longer "initialisation" since you dropped the frequency setup?
>
> > +     ret = dln2_i2c_enable(dln2, true);
> > +     if (ret < 0) {
> > +             dev_err(dev, "failed to initialize adapter: %d\n", ret);
>
> Same here.

Hmm, I still consider this to be an initialization operation, albeit
less complex then it was before. If you don't mind too much, I would
prefer to keep it this way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/