linux-kernel - Re: [PATCH v6 7/7] staging: skein: Removes skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141027131825.GA15252@titan.lakedaemon.net>
Date:	Mon, 27 Oct 2014 09:18:25 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Eric Rost <eric.rost@...abylon.net>
Cc:	gregkh@...uxfoundation.org, jake@....net, antonysaraev@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 7/7] staging: skein: Removes skein_debug include

On Fri, Oct 24, 2014 at 05:34:56PM -0500, Eric Rost wrote:
> Removes skein_debug.h include since skein_debug.h is nonexistent.
> 
> Signed-off-by: Eric Rost <eric.rost@...abylon.net>
> ---
>  drivers/staging/skein/skein_base.h | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/skein/skein_base.h b/drivers/staging/skein/skein_base.h
> index 0111fa4..5b69e5a 100644
> --- a/drivers/staging/skein/skein_base.h
> +++ b/drivers/staging/skein/skein_base.h
> @@ -15,10 +15,6 @@
>  **
>  ** The "default" note explains what happens when the switch is not defined.
>  **
> -**  SKEIN_DEBUG            -- make callouts from inside Skein code
> -**                            to examine/display intermediate values.
> -**                            [default: no callouts (no overhead)]
> -**
>  **  SKEIN_ERR_CHECK        -- how error checking is handled inside Skein
>  **                            code. If not defined, most error checking
>  **                            is disabled (for performance). Otherwise,
> @@ -282,15 +278,12 @@ int skein_1024_output(struct skein_1024_ctx *ctx, u8 *hash_val);
>  /*****************************************************************
>  ** "Internal" Skein definitions for debugging and error checking
>  ******************************************************************/
> -#ifdef SKEIN_DEBUG             /* examine/display intermediate values? */
> -#include "skein_debug.h"
> -#else                           /* default is no callouts */
>  #define skein_show_block(bits, ctx, x, blk_ptr, w_ptr, ks_event_ptr, ks_odd_ptr)
>  #define skein_show_round(bits, ctx, r, x)
>  #define skein_show_r_ptr(bits, ctx, r, x_ptr)
>  #define skein_show_final(bits, ctx, cnt, out_ptr)
>  #define skein_show_key(bits, ctx, key, key_bytes)

Are these called anywhere (sorry, away from dev box atm)?  If so, we
should remove those as well.

We shouldn't let this hold up the rest of the series, though.  I'll R-b
the rest and we'll keep working on this one.

thx,

Jason.

> -#endif
> +
>  
>  /* ignore all asserts, for performance */
>  #define skein_assert_ret(x, ret_code)
> -- 
> 2.1.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/