linux-kernel - Re: [PATCH 09/11] tty: ipwireless: Fix probable mask then right shift defects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1410271356050.20256@pobox.suse.cz>
Date:	Mon, 27 Oct 2014 15:17:28 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Joe Perches <joe@...ches.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:	linux-kernel@...r.kernel.org, David Sterba <dsterba@...e.cz>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH 09/11] tty: ipwireless: Fix probable mask then right
 shift defects

On Sun, 26 Oct 2014, Joe Perches wrote:

> Precedence of & and >> is not the same and is not left to right.
> shift has higher precedence and should be done after the mask.
> 
> Add parentheses around the masks.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Reviewed-by: Jiri Kosina <jkosina@...e.cz>

Greg, can you take this through your char/misc tree, please?

Thanks.

> ---
>  drivers/tty/ipwireless/hardware.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c
> index 2c14842..5c77e1e 100644
> --- a/drivers/tty/ipwireless/hardware.c
> +++ b/drivers/tty/ipwireless/hardware.c
> @@ -378,9 +378,9 @@ static void swap_packet_bitfield_to_le(unsigned char *data)
>  	/*
>  	 * transform bits from aa.bbb.ccc to ccc.bbb.aa
>  	 */
> -	ret |= tmp & 0xc0 >> 6;
> -	ret |= tmp & 0x38 >> 1;
> -	ret |= tmp & 0x07 << 5;
> +	ret |= (tmp & 0xc0) >> 6;
> +	ret |= (tmp & 0x38) >> 1;
> +	ret |= (tmp & 0x07) << 5;
>  	*data = ret & 0xff;
>  #endif
>  }
> @@ -393,9 +393,9 @@ static void swap_packet_bitfield_from_le(unsigned char *data)
>  	/*
>  	 * transform bits from ccc.bbb.aa to aa.bbb.ccc
>  	 */
> -	ret |= tmp & 0xe0 >> 5;
> -	ret |= tmp & 0x1c << 1;
> -	ret |= tmp & 0x03 << 6;
> +	ret |= (tmp & 0xe0) >> 5;
> +	ret |= (tmp & 0x1c) << 1;
> +	ret |= (tmp & 0x03) << 6;
>  	*data = ret & 0xff;
>  #endif
>  }
> -- 
> 2.1.2
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/