linux-kernel - Re: [PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpuiPqZ+5h-SS2-7XeVVh4J2v3SQr=RtjaTZw=0=bXABw@mail.gmail.com>
Date:	Mon, 27 Oct 2014 16:33:00 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	Mike Looijmans <mike.looijmans@...ic.nl>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Ball <chris@...ntf.net>
Subject: Re: [PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE_DEFER error messages

On 23 October 2014 13:47, Michal Simek <michal.simek@...inx.com> wrote:
> Hi Chris,
>
> On 10/23/2014 01:31 PM, Mike Looijmans wrote:
>> When the error code is -EPROBE_DEFER, this will already be reported
>> so don't emit an error message in that case.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
>> ---
>>  drivers/mmc/host/sdhci-of-arasan.c |    6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index 7ac6718..d5812a0 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -161,7 +161,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>>       host = sdhci_pltfm_init(pdev, &sdhci_arasan_pdata, 0);
>>       if (IS_ERR(host)) {
>>               ret = PTR_ERR(host);
>> -             dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
>> +             if (ret != -EPROBE_DEFER)
>> +                     dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
>>               goto clk_disable_all;
>>       }
>>
>> @@ -172,7 +173,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>>
>>       ret = sdhci_add_host(host);
>>       if (ret) {
>> -             dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
>> +             if (ret != -EPROBE_DEFER)
>> +                     dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
>>               goto err_pltfm_free;
>>       }
>
>
> I checked other drivers and they are not reporting these bugs. I have briefly looked
> at sdhci_add_host and sdhci_platfm_init and they are pretty good error description
> + core itself should report if driver probe failed.
> That's why I think that it is just reasonable to remove these both dev_err completely.
>
> What do you think?

I agree, this seems reasonable!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/