linux-kernel - Re: [PATCH] KVM: trivial fix comment regarding __kvm_set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <544E69E5.7040700@redhat.com>
Date:	Mon, 27 Oct 2014 16:51:01 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Dominik Dingel <dingel@...ux.vnet.ibm.com>
CC:	Gleb Natapov <gleb@...nel.org>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region

On 10/27/2014 04:22 PM, Dominik Dingel wrote:
> commit 72dc67a69690 ("KVM: remove the usage of the mmap_sem for the protection of the memory slots.")
> changed the lock which will be taken. This should be reflected in the function
> commentary.

Whoa, February 2008. :)

Thanks, applying this patch.

Paolo

> Signed-off-by: Dominik Dingel <dingel@...ux.vnet.ibm.com>
> ---
>  virt/kvm/kvm_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d82ec25..8b13607 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -738,7 +738,7 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm,
>   *
>   * Discontiguous memory is allowed, mostly for framebuffers.
>   *
> - * Must be called holding mmap_sem for write.
> + * Must be called holding kvm->slots_lock for write.
>   */
>  int __kvm_set_memory_region(struct kvm *kvm,
>  			    struct kvm_userspace_memory_region *mem)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/