| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1414433031.18896.2.camel@perches.com> Date: Mon, 27 Oct 2014 11:03:51 -0700 From: Joe Perches <joe@...ches.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: linux-kernel@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH 03/11] aiptek: Fix probable mask then right shift defects On Mon, 2014-10-27 at 11:01 -0700, Dmitry Torokhov wrote: > On Monday, October 27, 2014 10:56:54 AM Joe Perches wrote: > > On Mon, 2014-10-27 at 07:44 -0700, Dmitry Torokhov wrote: > > > On Sun, Oct 26, 2014 at 10:24:59PM -0700, Joe Perches wrote: > > > > Precedence of & and >> is not the same and is not left to right. > > > > shift has higher precedence and should be done after the mask. > > > > > > Looking at the protocol description the current code is exactly right. > > > We want to "move" button bits first as in packet type 1 they are in a > > > different place than in other packets. > > > > > > I'll take a patch that adds parenthesis around shifts to make clear it > > > is intended. > > > > I think it's more sensible to do the shift first to a > > temporary then direct comparisons. [] > Unless you have the device I'd rather kept the changes (which are mostly > cosmetic in nature and do not fix any bugs) to a minimum. I don't have the device. I think you should do what you think appropriate. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists