linux-kernel - Re: [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <544E99A4.4020906@amd.com>
Date:	Mon, 27 Oct 2014 14:14:44 -0500
From:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
To:	Arnd Bergmann <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	<mark.rutland@....com>, <will.deacon@....com>,
	<catalin.marinas@....com>,
	Thomas Lendacky <Thomas.Lendacky@....com>,
	Joel Schopp <Joel.Schopp@....com>, <marc.zyngier@....com>,
	<liviu.dudau@....com>, <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle
 platform

On 10/27/2014 2:07 PM, Arnd Bergmann wrote:
> On Monday 27 October 2014 13:54:25 suravee.suthikulpanit@....com wrote:
>> +       sata0: sata@...00000 {
>> +               compatible = "snps,spear-ahci";
>> +               reg = <0 0x300000 0 0x800>;
>> +               interrupts = <0 355 4>;
>> +               clocks = <&sataclk_333mhz>;
>> +               clock-names = "apb_pclk";
>> +               dma-coherent;
>> +       };
>
> Please use "snps,dwc-ahci" as the compatible string for a designware
> ahci controller, not "snps,spear-ahci", which refers to the implementation
> of that in the ST microelectronics SPEAr consumer SoC.
>
> It would be good to also add a string that is specific for your SoC if
> we ever need to identify it directly.
>
> 	Arnd
>

Thanks. I will update this in V3.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/