linux-kernel - Re: [PATCH] arm64: ARCH_PFN_OFFSET should be unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1971110.TLNM8kRvV0@wuerfel>
Date:	Tue, 28 Oct 2014 13:51:56 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Will Deacon <will.deacon@....com>,
	Neil Zhang <zhangwm@...vell.com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: ARCH_PFN_OFFSET should be unsigned long

On Tuesday 28 October 2014 12:36:11 Will Deacon wrote:
> On Tue, Oct 28, 2014 at 05:44:01AM +0000, Neil Zhang wrote:
> > pfns are unsigned long, but PHYS_PFN_OFFSET is phys_addr_t. This leads
> > to page_to_pfn() returning phys_addr_t which cause type mismatches in
> > some print statements.
> 
> Do you have a specific example? Both of those types are 64-bit on arm64.
> 
> 

printf warns about the fact that phys_addr_t is defined as 'u64', which
is 'unsigned long long' rather than 'unsigned long'. It's the same size
but not the same printf format string.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/