linux-kernel - Re: [PATCH 09/11] drivers: char: axd: add sysfs setup files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <544FAA96.9080006@imgtec.com>
Date:	Tue, 28 Oct 2014 14:39:18 +0000
From:	Qais Yousef <qais.yousef@...tec.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	<linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
	<alsa-devel@...a-project.org>
Subject: Re: [PATCH 09/11] drivers: char: axd: add sysfs setup files

On 10/28/2014 02:12 PM, Greg Kroah-Hartman wrote:
> On Tue, Oct 28, 2014 at 11:26:27AM +0000, Qais Yousef wrote:
>> +/* Control Device Sysfs Attributes */
>> +/* version */
>> +static ssize_t show_version(struct device *dev, struct device_attribute *attr,
>> +							char *buf)
>> +{
>> +	struct axd_cmd *cmd = (struct axd_cmd *)dev->platform_data;
>> +	int major, minor, patch;
>> +
>> +	axd_cmd_get_version(cmd, &major, &minor, &patch);
>> +	return sprintf(buf, "%u.%u.%u\n", major, minor, patch);
>> +}
>> +static DEVICE_ATTR(version, RD_PERMS, show_version, NULL);
> DEVICE_ATTR_RO() please.  Same for all other instances, you should never
> use DEVICE_ATTR() anymore.
>
> thanks,
>
> greg k-h

OK. I missed the transition to the new macro. I'll fix that.

Thanks,
Qais
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/