linux-kernel - Re: [PATCH RFC v2 8/8] ARM: zynq: DT: Add pinctrl information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda9v=H9rQBq484c+UCwEKeca9qOE_78Wf+STB4rDwhuyA@mail.gmail.com>
Date:	Tue, 28 Oct 2014 16:05:18 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Soren Brinkmann <soren.brinkmann@...inx.com>
Cc:	Michal Simek <michal.simek@...inx.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Subject: Re: [PATCH RFC v2 8/8] ARM: zynq: DT: Add pinctrl information

On Thu, Oct 16, 2014 at 7:11 PM, Soren Brinkmann
<soren.brinkmann@...inx.com> wrote:

> Add pinctrl descriptions to the zc702 and zc706 device trees.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>

(...)
> +&pinctrl0 {
> +       pinctrl_can0_default: pinctrl-can0-default {
> +               common {
> +                       function = "can0";
> +                       groups = "can0_9_grp";
> +                       bias-pull-up = <0>;

No. If you want pull-up, just use
bias-pull-up;

If you want to disable pull-up, use
bias-disable;

> +                       slew-rate = <0>;

If this measure is any kind of time unit, this is against the laws of nature.

> +                       io-standard = <1>;
> +               };
> +
> +               rx {
> +                       pins = "MIO46";
> +                       bias-high-impedance = <1>;

Just
bias-high-impedance;

> +               };
> +
> +               tx {
> +                       pins = "MIO47";
> +                       bias-high-impedance = <0>;

Just
bias-disable;

Look all these over closely.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/