lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Oct 2014 16:51:50 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Doug Anderson <dianders@...omium.org>, Heiko Stuebner <heiko@...ech.de> Cc: Chris Zhong <zyw@...k-chips.com>, Sonny Rao <sonnyrao@...omium.org>, linux-rockchip@...ts.infradead.org, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/4] pinctrl: rockchip: Set wake_enabled On Tue, Oct 21, 2014 at 1:27 AM, Doug Anderson <dianders@...omium.org> wrote: > The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup > the .wake_enabled member. That means that we can never actually use a > pin for wakeup. When "irq_set_irq_wake()" tries to call through it > will always get a failure from set_irq_wake_real() and will then set > wake_depth to 0. Assuming you can resume you'll later get an error > message about "Unbalanced IRQ x wake disable". > > Signed-off-by: Doug Anderson <dianders@...omium.org> Heiko, are you looking at this patch series? Need you Reviewed-by to merge this stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists