linux-kernel - Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hvbn46t0s.wl-tiwai@suse.de>
Date:	Tue, 28 Oct 2014 17:47:15 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Mark Brown <broonie@...nel.org>, Max Filippov <jcmvbkbc@...il.com>,
	alsa-devel@...a-project.org, Mark Rutland <mark.rutland@....com>,
	devicetree@...r.kernel.org, Pawel Moll <pawel.moll@....com>,
	linux-xtensa@...ux-xtensa.org,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

At Tue, 28 Oct 2014 17:39:13 +0100,
Lars-Peter Clausen wrote:
> 
> On 10/28/2014 05:04 PM, Mark Brown wrote:
> > On Tue, Oct 28, 2014 at 04:58:24PM +0100, Lars-Peter Clausen wrote:
> >> On 10/27/2014 08:07 PM, Max Filippov wrote:
> >
> >>> +	if (tx_active) {
> >>> +		if (i2s->tx_fifo_high < 256)
> >>> +			xtfpga_i2s_refill_fifo(i2s);
> >>> +		else
> >>> +			tasklet_hi_schedule(&i2s->refill_fifo);
> >
> >> Maybe use threaded IRQs instead of IRQ + tasklet.
> >
> > Is that going to play nicely with the fact that the interrupt can be
> > shared and the desire to (AFAICT) do NAPI style stuff with the interrupt
> > disabled for long periods?
> >
> 
> Threaded interrupts got support for interrupt sharing a while ago, so I 
> guess yes. I think it will even work better than the tasklet approach. You 
> can configure the IRQ to disable itself as long as the thread is running.

Yes, I tested the threaded irq with PCI drivers using shared irqs and
worked well. 


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/