linux-kernel - Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141028165827.GG15252@titan.lakedaemon.net>
Date:	Tue, 28 Oct 2014 12:58:27 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Jonathan Corbet <corbet@....net>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Rob Landley <rob@...dley.net>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Paul Bolle <pebolle@...cali.nl>,
	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [patch] Documentation/SubmittingPatches: Reported-by tags and
 permission

On Tue, Oct 28, 2014 at 09:04:51AM -0400, Jonathan Corbet wrote:
> On Fri, 14 Feb 2014 12:30:01 +0300
> Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> > -If this patch fixes a problem reported by somebody else, consider adding a
> > -Reported-by: tag to credit the reporter for their contribution.  Please
> > -note that this tag should not be added without the reporter's permission,
> > -especially if the problem was not reported in a public forum.  That said,
> > -if we diligently credit our bug reporters, they will, hopefully, be
> > -inspired to help us again in the future.
> > +The Reported-by tag is to give credit to people who find bugs and report them.
> > +Please note that if the bug was reported in private, then ask for permission
> > +first before using the Reported-by tag.
> 
> As the guy who wrote the original text, I think this is an
> improvement...but can we get a version that retains the motivation for
> crediting bug reporters in the first place?

At the risk of upsetting the apple cart, I'd prefer we downplay anything
that walks down the path of gamification (by focusing on credit).

As best anyone has ever explained it to me, the Acked-by, Reviewed-by,
etc are there to impart information regarding a specific commit.  In the
event that a commit is fingered in a bisect, you have a much better list
of names to Cc, instead of just the maintainer from MAINTAINERS and the
author from the top of the offending file.  The author has often moved
on, and the maintainer may not have been around for the bugfix.

I know Greg has spoken out against gamification before, and I also
understand the desire to encourage bug reporters.  Perhaps I should just
suggest the following:

"""
The Reported-by tag helps us maintain contact info for people with
intimate knowledge of a commit or a bug fix.  Please seek the reporter's
permission before adding the tag to the commit.  That said, if we
diligently credit our bug reporters, they will, hopefully, be inspired
to help us again in the future.
"""

It's most likely ok here since it's rather hard to manufacture a list of
bugs in order to inflate ones count of Reported-by's.  Unlike S-o-b,
Ack's, etc.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/