linux-kernel - Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141028170644.GC18557@sirena.org.uk>
Date:	Tue, 28 Oct 2014 17:06:44 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Max Filippov <jcmvbkbc@...il.com>, alsa-devel@...a-project.org,
	Mark Rutland <mark.rutland@....com>,
	devicetree@...r.kernel.org, Pawel Moll <pawel.moll@....com>,
	linux-xtensa@...ux-xtensa.org, Takashi Iwai <tiwai@...e.de>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and
 platform

On Tue, Oct 28, 2014 at 05:39:13PM +0100, Lars-Peter Clausen wrote:
> On 10/28/2014 05:04 PM, Mark Brown wrote:

> >Is that going to play nicely with the fact that the interrupt can be
> >shared and the desire to (AFAICT) do NAPI style stuff with the interrupt
> >disabled for long periods?

> Threaded interrupts got support for interrupt sharing a while ago, so I
> guess yes. I think it will even work better than the tasklet approach. You
> can configure the IRQ to disable itself as long as the thread is running.

I know you *can* share threaded interrupts, I'm just not sure that
hogging the threaded handler plays nicely with other users.  Though now
I look at this again tx_fifo_high is a "constant" so it's not actually
trying to do a NAPI type mitigation thing and this is really just an
open coded threaded interrupt as you say.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)