| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141028192305.GB12033@roeck-us.net> Date: Tue, 28 Oct 2014 12:23:05 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Florian Fainelli <f.fainelli@...il.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 01/15] net: dsa: Don't set skb->protocol on outgoing tagged packets On Tue, Oct 28, 2014 at 12:19:21PM -0700, Florian Fainelli wrote: > On 10/26/2014 09:52 AM, Guenter Roeck wrote: > > Setting skb->protocol to a private protocol type may result in warning > > messages such as > > e1000e 0000:00:19.0 em1: checksum_partial proto=dada! > > > > This happens if the L3 protocol is IP or IPv6 and skb->ip_summed is set > > to CHECKSUM_PARTIAL. Looking through the code, it appears that changing > > skb->protocol for transmitted packets is not necessary and may actually > > be harmful. Drop it. > > You could emphasize that overriding skb->protocol prevents purposely > unmodified (from a DSA perspective) network drivers from properly > setting up their transmit checksum offload pointers since they inspect > skb->protocol to setup the IPv4 header or IPv6 header pointers. > Ok, I'll do that. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists