linux-kernel - Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2740724.5yjNTKs1RY@vostro.rjw.lan>
Date:	Tue, 28 Oct 2014 22:59:57 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Arnd Bergmann <arnd@...db.de>
Cc:	Darren Hart <dvhart@...ux.intel.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

On Tuesday, October 28, 2014 01:15:27 PM Mika Westerberg wrote:
> acpi_dev_add_driver_gpios() makes it possible to set up mapping between
> properties and ACPI GpioIo resources in a driver, so we can take index
> parameter in acpi_find_gpio() into use with _DSD device properties now.
> 
> This index can be used to select a GPIO from a property with multiple
> GPIOs:
> 
>   Package () {
>   	"data-gpios",
>   	Package () {
>   		\_SB.GPIO, 0, 0, 0,
>   		\_SB.GPIO, 1, 0, 0,
>   		\_SB.GPIO, 2, 0, 1,
>   	}
>   }
> 
> In order to retrieve the last GPIO from a driver we can simply do:
> 
>   desc = devm_gpiod_get_index(dev, "data", 2);
> 
> and so on.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Cool. :-)

Any objections anyone?

> ---
> This is on top of latest linux-pm/device-properties.
> 
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index fbf717a56b0a..58659dbe702a 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1522,7 +1522,7 @@ static struct gpio_desc *acpi_find_gpio(struct device *dev, const char *con_id,
>  				 suffixes[i]);
>  		}
>  
> -		desc = acpi_get_gpiod_by_index(adev, propname, 0, &info);
> +		desc = acpi_get_gpiod_by_index(adev, propname, idx, &info);
>  		if (!IS_ERR(desc) || (PTR_ERR(desc) == -EPROBE_DEFER))
>  			break;
>  	}
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/