linux-kernel - Re: [Patch v7 05/18] ACPI: Correct return value of acpi_dev_resource_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Oct 2014 19:13:57 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Jiang Liu <jiang.liu@...ux.intel.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Borislav Petkov <bp@...en8.de>, Len Brown <lenb@...nel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Joerg Roedel <joro@...tes.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [Patch v7 05/18] ACPI: Correct return value of acpi_dev_resource_address_space()

On Mon, Oct 27, 2014 at 5:11 PM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> On Monday, October 27, 2014 04:49:06 PM Bjorn Helgaas wrote:
>> On Sun, Oct 26, 2014 at 11:21 PM, Jiang Liu <jiang.liu@...ux.intel.com> wrote:
>> > Change acpi_dev_resource_address_space() to return failure if the
>> > acpi_resource structure can't be converted to an ACPI address64
>> > structure, so caller could correctly detect failure.
>>
>> Fixes: 046d9ce6820e ("ACPI: Move device resources interpretation code
>> from PNP to ACPI core")
>>
>> Possible stable candidate?  046d9ce6820e appeared in v3.8.
>
> Well, are we seeing problems with it?

Not to my knowledge.  I only raised the possibility because it seems
like we are seeing more and more things backported to stable.  But if
we we're not seeing a problem, I agree we probably shouldn't push it.

>> > Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
>> > ---
>> >  drivers/acpi/resource.c |    2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
>> > index 2ba8f02ced36..782a0d15c25f 100644
>> > --- a/drivers/acpi/resource.c
>> > +++ b/drivers/acpi/resource.c
>> > @@ -200,7 +200,7 @@ bool acpi_dev_resource_address_space(struct acpi_resource *ares,
>> >
>> >         status = acpi_resource_to_address64(ares, &addr);
>> >         if (ACPI_FAILURE(status))
>> > -               return true;
>> > +               return false;
>> >
>> >         res->start = addr.minimum;
>> >         res->end = addr.maximum;
>> > --
>> > 1.7.10.4
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/