linux-kernel - Re: [PATCH V4] kernel, add bug_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141028023251.GD3329@darkstar.nay.redhat.com>
Date:	Tue, 28 Oct 2014 10:32:51 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	Jason Baron <jbaron@...mai.com>, Andi Kleen <ak@...ux.intel.com>,
	Jonathan Corbet <corbet@....net>, kexec@...ts.infradead.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Fabian Frederick <fabf@...net.be>,
	isimatu.yasuaki@...fujitsu.com, "H. Peter Anvin" <hpa@...or.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-api@...r.kernel.org, vgoyal@...hat.com
Subject: Re: [PATCH V4] kernel, add bug_on_warn

> > Seems reasonable-I'm wondering why you just don't call panic() in this
> > case. The BUG() call at line '434' doesn't at anything since its just being
> > called from panic.c.
> 
> Hmm ... I didn't even think about that.
> 
> > 
> > So something like 'panic_on_warn' would seem to be more appropriate
> > in keeping with things like 'panic_on_oops' or 'panic_on_stackoverflow'.
> 
> I like it a lot better that way too :)  I'm changing it to panic_on_warn unless
> anyone has any strenuous objections.

I would vote for panic_on_warn, it will make more sense than bug_on_warn.

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/