linux-kernel - Re: [RFA][PATCH 8/8] debugfs: Have debugfs_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141029193701.57c65191@gandalf.local.home>
Date:	Wed, 29 Oct 2014 19:37:01 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Joe Perches <joe@...ches.com>
Subject: Re: [RFA][PATCH 8/8] debugfs: Have debugfs_print_regs32() return
 void

On Wed, 29 Oct 2014 15:03:15 -0700
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Wed, Oct 29, 2014 at 05:56:10PM -0400, Steven Rostedt wrote:
> > From: Joe Perches <joe@...ches.com>
> > 
> > [ REQUEST FOR ACKS ]
> > 
> > The seq_printf() will soon just return void, and seq_has_overflowed()
> > should be used instead to see if the seq can no longer accept input.
> > 
> > As the return value of debugfs_print_regs32() has no users and
> > the seq_file descriptor should be checked with seq_has_overflowed()
> > instead of return values of functions, it is better to just have
> > debugfs_print_regs32() also return void.
> > 
> > Link: http://lkml.kernel.org/p/2634b19eb1c04a9d31148c1fe6f1f3819be95349.1412031505.git.joe@perches.com
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > [ original change only updated seq_printf() return, added return of
> >   void to debugfs_print_regs32() as well ]
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> > ---
> 
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/