linux-kernel - Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tx2njooz.fsf@intel.com>
Date:	Wed, 29 Oct 2014 09:54:36 +0200
From:	Jani Nikula <jani.nikula@...el.com>
To:	Michael Ellerman <mpe@...erman.id.au>,
	Randy Dunlap <rdunlap@...radead.org>
Cc:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	linux-fbdev@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>,
	Daniel Drake <dsd@...top.org>,
	Jens Frederich <jfrederich@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	platform-driver-x86@...r.kernel.org,
	Lee Jones <lee.jones@...aro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Darren Hart <dvhart@...radead.org>,
	Daniel Vetter <daniel.vetter@...el.com>,
	Bryan Wu <cooloney@...il.com>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

On Wed, 29 Oct 2014, Michael Ellerman <mpe@...erman.id.au> wrote:
> On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote:
>> On 10/27/14 06:13, Tomi Valkeinen wrote:
>> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE ||
>> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds
>> > like a hack to me =).
>> 
>> It does exactly what is needed and it is used in many places in kernel
>> Kconfig files.
>
> Is there any reason you can't do:
>
>   depends on BACKLIGHT_CLASS_DEVICE != m

That's not the same thing. The FOO || FOO=n allows for all options, but
forbids it being a module when the option depending on it is
built-in. Obviously something that's built-in can't depend on something
built as a module.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/