linux-kernel - Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141029085429.GJ1304@lahna.fi.intel.com>
Date:	Wed, 29 Oct 2014 10:54:29 +0200
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Alexandre Courbot <acourbot@...dia.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linus Walleij <linus.walleij@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Darren Hart <dvhart@...ux.intel.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index()
 when using properties

On Wed, Oct 29, 2014 at 04:41:47PM +0900, Alexandre Courbot wrote:
> On 10/29/2014 06:59 AM, Rafael J. Wysocki wrote:
> >On Tuesday, October 28, 2014 01:15:27 PM Mika Westerberg wrote:
> >>acpi_dev_add_driver_gpios() makes it possible to set up mapping between
> >>properties and ACPI GpioIo resources in a driver, so we can take index
> >>parameter in acpi_find_gpio() into use with _DSD device properties now.
> >>
> >>This index can be used to select a GPIO from a property with multiple
> >>GPIOs:
> >>
> >>   Package () {
> >>   	"data-gpios",
> >>   	Package () {
> >>   		\_SB.GPIO, 0, 0, 0,
> >>   		\_SB.GPIO, 1, 0, 0,
> >>   		\_SB.GPIO, 2, 0, 1,
> >>   	}
> >>   }
> >>
> >>In order to retrieve the last GPIO from a driver we can simply do:
> >>
> >>   desc = devm_gpiod_get_index(dev, "data", 2);
> >>
> >>and so on.
> >>
> >>Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> >
> >Cool. :-)
> >
> >Any objections anyone?
> 
> Looks good to me!
> 
> Acked-by: Alexandre Courbot <acourbot@...dia.com>

Thanks!

> Since this looks like a bug fix, shouldn't this be squashed into the
> relevant patch of the device-properties set?

I agree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/