linux-kernel - Re: CRISv32: ETRAX_SPI_MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Oct 2014 10:33:20 +0100
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Jesper Nilsson <jespern@...s.com>,
	Valentin Rothberg <valentinrothberg@...il.com>,
	Mikael Starvik <starvik@...s.com>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: CRISv32: ETRAX_SPI_MMC_BOARD

On Wed, Oct 29, 2014 at 09:20:54AM +0100, Paul Bolle wrote:
> Jesper,

Hi Paul!

> Your commit be64c1ce6e79 ("CRISv32: Drop obsolete file for SPI driver")
> landed in today's linux-next (ie, next-20141029). It removes the last
> user of the Kconfig symbol ETRAX_SPI_MMC_BOARD. Setting that symbol is
> now pointless.
> 
> Is the trivial patch to remove the entry for ETRAX_SPI_MMC_BOARD (and
> one select statement for it) queued somewhere? If not, should I submit
> it?

It was not, but it is now:

CRISv32: Remove last remnants of ETRAX_SPI_MMC_BOARD

There are no users of this symbol left.

Reported-by: Paul Bolle <pebolle@...cali.nl>
Signed-off-by: Jesper Nilsson <jesper.nilsson@...s.com>
---
 arch/cris/arch-v32/drivers/Kconfig |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/cris/arch-v32/drivers/Kconfig b/arch/cris/arch-v32/drivers/Kconfig
index 6880f94..7068c4b 100644
--- a/arch/cris/arch-v32/drivers/Kconfig
+++ b/arch/cris/arch-v32/drivers/Kconfig
@@ -361,13 +361,6 @@ config ETRAX_SPI_MMC
 	default MMC
 	select SPI
 	select MMC_SPI
-	select ETRAX_SPI_MMC_BOARD
-
-# For the parts that can't be a module (due to restrictions in
-# framework elsewhere).
-config ETRAX_SPI_MMC_BOARD
-       boolean
-       default n
 
 # While the board info is MMC_SPI only, the drivers are written to be
 # independent of MMC_SPI, so we'll keep SPI non-dependent on the
-- 
1.7.10.4


I'll try to think about unreferenced kconfigs in the future,
my suspicion is that all those SPI and MMC related configs are
also unused, just circular references keeping them unnoticed.

Thanks for the heads up.

> Paul Bolle

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/