lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Oct 2014 11:37:09 +0200 From: Roger Quadros <rogerq@...com> To: Frans Klaver <fransklaver@...il.com>, Rostislav Lisovy <lisovy@...il.com> CC: David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Tony Lindgren <tony@...mide.com>, <linux-mtd@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, <michal.vokac@...ap.cz>, <sojkam1@....cvut.cz>, Rostislav Lisovy <lisovy@...ica.cz> Subject: Re: [PATCH v3 2/2] mtd: nand: omap: Synchronize the access to the ECC engine Hi Rostislav, Sorry to miss this one. On 10/29/2014 11:24 AM, Frans Klaver wrote: > On Thu, Oct 2, 2014 at 4:16 PM, Rostislav Lisovy <lisovy@...il.com> wrote: >> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c >> index f0dcdb6..dfae46f 100644 >> --- a/drivers/mtd/nand/omap2.c >> +++ b/drivers/mtd/nand/omap2.c >> @@ -144,8 +144,13 @@ static u_char bch8_vector[] = {0xf3, 0xdb, 0x14, 0x16, 0x8b, 0xd2, 0xbe, 0xcc, >> 0xac, 0x6b, 0xff, 0x99, 0x7b}; >> static u_char bch4_vector[] = {0x00, 0x6b, 0x31, 0xdd, 0x41, 0xbc, 0x10}; >> >> +/* Shared among all NAND instances to synchronize the access to the ECC Engine */ >> +struct nand_hw_control omap_gpmc_controller = { >> + .lock = __SPIN_LOCK_UNLOCKED(omap_gpmc_controller.lock), >> + .wq = __WAIT_QUEUE_HEAD_INITIALIZER(omap_gpmc_controller.wq), >> +}; >> + > > Any reason not to make this one static? > Right. Apart from that, this patch looks good for me. So after that change you can add my Acked-by: Roger Quadros <rogerq@...com> cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists