linux-kernel - Re: [PATCH] of: spi: Export single device registration method and accessors (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6A3753C0-251A-4645-AD96-CB1D6521175F@antoniou-consulting.com>
Date:	Wed, 29 Oct 2014 13:48:06 +0200
From:	Pantelis Antoniou <panto@...oniou-consulting.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Alexander Sverdlin <alexander.sverdlin@....com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <robherring2@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Matt Porter <matt.porter@...aro.org>,
	Koen Kooi <koen@...inion.thruhere.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alison Chaiken <Alison_Chaiken@...tor.com>,
	Dinh Nguyen <dinh.linux@...il.com>,
	Jan Lubbe <jluebbe@...net.de>, Michael Stickel <ms@...able.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Dirk Behme <dirk.behme@...il.com>,
	Alan Tull <delicious.quinoa@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Michael Bohan <mbohan@...eaurora.org>,
	Ionut Nicu <ioan.nicu.ext@....com>,
	Michal Simek <monstr@...str.eu>,
	Matt Ranostay <mranostay@...il.com>,
	Joel Becker <jlbec@...lplan.org>, devicetree@...r.kernel.org,
	Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
	linux-spi@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Pete Popov <pete.popov@...sulko.com>,
	Dan Malek <dan.malek@...sulko.com>,
	Georgi Vlaev <georgi.vlaev@...sulko.com>
Subject: Re: [PATCH] of: spi: Export single device registration method and accessors (v2)

Hi

> On Oct 29, 2014, at 12:14 , Mark Brown <broonie@...nel.org> wrote:
> 
> On Wed, Oct 29, 2014 at 10:40:37AM +0200, Pantelis Antoniou wrote:
>> Dynamically inserting spi device nodes requires the use of a single
>> device registration method. Rework and export it.
>> 
>> Methods to lookup a device/master using a device node are added
>> as well, of_find_spi_master_by_node() & of_find_spi_device_by_node().
> 
> Why do we need to do this - I would expect that adding nodes would
> trigger parsing in the same way we normally do it.  Where is the user
> and how does it know that it's handling a SPI node?
> 
> This feels like there is an abstraction problem somewhere, whatever code
> is supposed to use this is going to need to be taught about each
> individual bus which is going to be tedious, I would expect that we'd
> have something like the bus being able to provide a callback which will
> get invoked whenever a new node appears on the parent node for the bus.
> 

There’s a whole patchset that does exactly this. 
Look at "OF: spi: Add OF notifier handler” and you’ll where this is used.

>> Changes since v1:
>> * Brown paper bug with parameter on of_register_spi_device().
> 
> Don't include noise like this in the changelog, put it after --- like
> SubmittingPatches says.  Please also try to keep your CC list sane,
> CCing random people just means that you're increasing the volume of mail
> they have to process.  I'm surprised kernel.org accepts so many CCs.
> 
> I have to say I don't recall ever seeing v1...

All of them are in the CC list for a reason. 

Regards

— Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/