linux-kernel - Re: [PATCH v2 1/1] staging: skein: Removes skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Oct 2014 09:54:26 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Eric Rost <eric.rost@...abylon.net>
Cc:	gregkh@...uxfoundation.org, jake@....net, antonysaraev@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] staging: skein: Removes skein_debug include

Eric,

Much better.  One small nit below:

On Tue, Oct 28, 2014 at 06:44:31PM -0500, Eric Rost wrote:
> Removes skein_debug.h include since skein_debug.h is nonexistent.
> Removes unneeded debug empty macro defines and their uses.
> 
> Signed-off-by: Eric Rost <eric.rost@...abylon.net>
> ---
>  drivers/staging/skein/skein_base.c  | 18 ------------------
>  drivers/staging/skein/skein_base.h  | 17 -----------------
>  drivers/staging/skein/skein_block.c | 30 +-----------------------------
>  3 files changed, 1 insertion(+), 64 deletions(-)
> 
...
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
> index 36b0b40..289bf13 100644
> --- a/drivers/staging/skein/skein_block.c
> +++ b/drivers/staging/skein/skein_block.c
...
> @@ -422,9 +409,6 @@ void skein_256_process_block(struct skein_256_ctx *ctx, const u8 *blk_ptr,
>  		X3 = w[3] + ks[3];
>  
>  		/* show starting state values */
> -		skein_show_r_ptr(BLK_BITS, &ctx->h, SKEIN_RND_KEY_INITIAL,
> -				 x_ptr);
> -

Please remove the comment here as well.

>  		blk_ptr += SKEIN_256_BLOCK_BYTES;
>  
>  		/* run the rounds */

Fix that up and please add my:

Reviewed-by: Jason Cooper <jason@...edaemon.net>

to the next version (below your Signed-off-by:).

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/